solidjs / solidjs/solid-vite-plugin
During dev mode, each time node_modules package imports file internally, makes that module have unique identity.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 520
- Forks
- 70
- Avg merge
- 23h 35m
- Merged PRs (30d)
- 39
Description
During dev mode, each time node_modules package imports file internally, makes that module have unique identity.
// inside node_modules/some-package
// a.js
export const uniqueVariable = {}
// b.jsx
import { uniqueVariable } from './a'
export compare = (variable) => uniqueVariable === variable
// index.jsx
import { uniqueVariable } from './a'
import { compare } from './b'
compare(uniqueVariable) // Produces false
After updating to latest Solid version, from Solid 1.4.4 I noticed that useContext broke with my library, and that lead me to discovering this issue. The issue only occurs during dev mode and only inside with node_modules.
I manually edited node_module of my package to check.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked reproduction and compare the module imports shown in a.js, b.jsx, and index.jsx during dev mode. Trace why the package's internal imports produce distinct module identities, then verify that compare(uniqueVariable) no longer returns false in the reproduction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vite
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100