solidjs / solidjs/solid-vite-plugin
vite-plugin-solid 2.11.2 and onwards (up to 2.11.6) breaks unplugin-icons/vite with "solid" icon compiler
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 520
- Forks
- 70
- Avg merge
- 23h 35m
- Merged PRs (30d)
- 39
Description
Hello Folks,
maybe I'm wrong here, I'll also make an Issue in the unplugin-icons/vite repo.
See: https://github.com/unplugin/unplugin-icons/issues/399
Anyways, this is the issue:
When Installing vite-plugin-solid 2.11.2, I get the following issue with unplugin-icons/vite:
For some reason, this unplugin tag is not compiled for solid but for react:
<FolderFullIcon class="mb-[3px] inline text-slate-600" />
This issue is not present in vite-plugin-solid 2.11.1:
What regression could that be?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing vite-plugin-solid 2.11.1 with 2.11.2 through 2.11.6 and reproduce the interaction with unplugin-icons/vite, using the linked unplugin issue as context. Trace why the solid icon compiler produces React-style output; done means the same icon is compiled for Solid again with the affected plugin versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript, vite
- Domain
- build-system, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100