solidjs / solidjs/solid-vite-plugin
alias normalization breaks config
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 520
- Forks
- 70
- Avg merge
- 23h 35m
- Merged PRs (30d)
- 39
Description
Repro: https://stackblitz.com/edit/vitejs-vite-z8v1wp?file=vite.config.js
It only errors when vite-plugin-solid is active:
Failed to load url /node_modules/path-browserify/posix (resolved id: /home/projects/vitejs-vite-z8v1wp/node_modules/path-browserify/posix) in /home/projects/vitejs-vite-z8v1wp/main.js. Does the file exist?
Specifically this line:
https://github.com/solidjs/vite-plugin-solid/blob/2b37a130f9f2cbece9e27bbdce6b67f16424866f/src/index.ts#L310
Seems like the normalization is not needed anymore since f3b10b55195fbff96d74a96ae69632cc9f55b6ba and can be removed (works fine based on my tests).
I'll also try to find the root cause in vite or @rollup/plugin-alias.
Related: https://github.com/davidmyersdev/vite-plugin-node-polyfills/issues/48#issuecomment-1868104140
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with the linked StackBlitz project and inspect src/index.ts around line 310. Compare the normalization there with commit f3b10b55195fbff96d74a96ae69632cc9f55b6ba, then check whether Vite or @rollup/plugin-alias is involved. Done means the configuration works with vite-plugin-solid active without the reported path-browserify/posix error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vite
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100