solidjs / solidjs/solid-vite-plugin

Object destructuring inside namespaces causes other exports to disappear

Open
#113 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
520
Forks
70
Avg merge
23h 35m
Merged PRs (30d)
39

Description

I have a file containing the following code:

namespace B {
    export function c() { }
}

export namespace A {
    export const { c } = B; 
    export function a() { }
    export function b() { }
}

console.log(A);

When building it with vite it gets turned to this:

(function (global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
    typeof define === 'function' && define.amd ? define(['exports'], factory) :
    (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.alfa = {}));
})(this, (function (exports) { 'use strict';

    var B;
    ((B2) => {
      function c() {
      }
      B2.c = c;
    })(B || (B = {}));
    exports.A = void 0;
    ((A2) => {
      ({ c: A2.c } = B);
      function a() {
      }
      A2.a = a;
      function b() {
      }
      A2.b = b;
    })(exports.A || (exports.A = {}));
    console.log(exports.A);

    Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });

}));

And if I run it, it logs { c: [Function: c], a: [Function: a], b: [Function: b] }.
If I use vite-plugin-solid AND the file is a .tsx, the build result is the following:

(function (global, factory) {
    typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
    typeof define === 'function' && define.amd ? define(['exports'], factory) :
    (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.alfa = {}));
})(this, (function (exports) { 'use strict';

    let B;
    (function (_B) {
      function c() {}
      _B.c = c;
    })(B || (B = {}));
    exports.A = void 0;
    (function (_A) {
      const {
        c
      } = B;
      _A.c = c;
      function b() {}
      _A.b = b;
    })(exports.A || (exports.A = {}));
    console.log(exports.A);

    Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
}));

And it outputs { c: [Function: c], b: [Function: b] } when ran.
Why does "A.a" gets removed from the namespace?
Moreover, why does changing the code like this works?

namespace B {
    export function c() { }
}

export namespace A {
    export function a() { }
    export function b() { }
    export const { c } = B; // ← Moved on the bottom of the namespace
}

console.log(A);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the namespace and object-destructuring example in both a .ts build and a .tsx build using vite-plugin-solid, then compare the generated output. Trace why the transformed .tsx namespace omits A.a, and consider the issue resolved when all declared exports remain available at runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vite
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.