solidjs / solidjs/solid-router
[Feature ✨] Support for contextual modal navigation
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 180
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 19
Description
I apologize if I am posting in the wrong place but https://github.com/solidjs/solid-app-router/discussions gives me 404.
Basically I was trying to implement contextual modal navigation where the navigation path the user takes determines if the page is rendered in the modal or not -- basically like in this React example. However, it seems setting location like this is not possible with solid-app-router. Am I missing something or simply this is not supported at the moment?
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the React modal navigation example linked in the issue, then inspect solid-app-router's handling of location and navigation state. Define how navigation history should determine modal versus full-page rendering, and verify that both contextual entry and direct URL entry behave as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100