solidjs / solidjs/solid-playground

`console.warn` only shown when clicking "output" tab

Open
#190 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
244
Forks
69
PR merge metrics
No merged PRs in 30d

Description

Ryan noted that markup validation wasn't shown as an error https://discord.com/channels/722131463138705510/817960620736380928/1428818452168048671

We use console.warn and do not throw for that particular case, but even then the warning is only shown when clicking the "output" tab.
https://playground.solidjs.com/anonymous/484af2b6-3962-4b27-b978-2bd01ad7d660

Could be also considered to show console.warn as errors(message below code), not sure if that were a thing before

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the warning with the linked Solid Playground example and inspect the code responsible for handling console.warn output and rendering the "output" tab. Determine the intended visible behavior for warnings, then verify that the warning appears without requiring the tab to be clicked and that existing output behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.