solarwinds / solarwinds/nova

SorterComponent layout is broken in certain circumstances

Open
#397 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
27
Forks
33
Avg merge
8h 53m
Merged PRs (30d)
5

Description

When there is not enough horizontal space for a SorterComponent, it's trigger button goes below the main button and the layout doesn't look good. This behavior was introduced in v11 - the component look used to remain solid in earlier versions.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://nova-ui.solarwinds.io/#/bits/release_v11.8.x/components/SorterComponent.html
  2. Make your browser window very narrow / zoom in the page

Expected behavior
The component looks solid.

Screenshots
Current look:
2021-08-04_10-42-36

Correct look (v9 or lower):
2021-08-04_10-41-10

Environment (please complete the following information):

  • OS: Mac OS
  • Browser: chrome, safari
  • Browser Version: actual

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the SorterComponent demo at the v11.8.x release URL with a narrow or zoomed browser window. Inspect the SorterComponent implementation and its layout styling, using the v9-or-lower appearance as the reference. Done means the trigger button no longer drops below the main button when horizontal space is limited.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.