softwaremill / softwaremill/tapir

When an invalid message (which errors on decoding) is sent to a WS endpoint, the WS is not closed

Open
#4,291 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

zio
Dominant language
Scala
Stars
1.5k
Forks
468
Avg merge
5h 37m
Merged PRs (30d)
34

Description

Additionally, an ERROR-level message is logged, while it should be WARN at most (since this is a client error, not a bug)

See e.g. WebSocketZioHttpJsonServer

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at WebSocketZioHttpJsonServer and trace how invalid messages that fail during decoding are handled. Verify the WebSocket is closed and the event is logged at WARN rather than ERROR; the relevant tests are not named in the issue, so locate the existing WebSocket test coverage first.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.