softwaremill / softwaremill/tapir

Define a single TapirPickle instance, instead of subclassing?

Open
#3,192 2 comments 0 reactions 1 assignee View on GitHub

@kciesielski is already working on this.

Since Sep 28, 2023.

Pickler
Dominant language
Scala
Stars
1.5k
Forks
468
Avg merge
5h 37m
Merged PRs (30d)
34

Description

Could we use a single TapirPickle instance, instead of subclassing TapirPickle for every modification (asOption/ asArray, etc.). Then in Pickler, maybe we could simply require values of type Types#Reader? or TapirPickle.Reader (from the single instance)? That way we could avoid the instanceOfs. (btw. why readers and writers are separate?)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.