softwaremill / softwaremill/tapir

Finatra server interpreter: improve file output

Open
#259 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

implementation server
Dominant language
Scala
Stars
1.5k
Forks
468
Avg merge
5h 37m
Merged PRs (30d)
34

Description

In FinatraRequestToRawBody, when saving the body to a file, the content should be streamed, not read entirely into memory (as it is now with serverOptions.createFile(asByteArray)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating FinatraRequestToRawBody and the call to serverOptions.createFile(asByteArray). Trace how the request body is obtained and how file output is created; the work is done when the body is streamed to the file without being read entirely into memory.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.