softwaremill / softwaremill/macwire
Consider banning primitive types from wiring candidates
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.3k
- Forks
- 77
- Avg merge
- 9m
- Merged PRs (30d)
- 4
Description
Sometimes if you forget to add a dependency to autowire's parameters which needs manual creation you get errors such as a missing String dependency (if a String is needed to create said instance).
Maybe we should short-circuit even earlier, that is report an error any time someone tries to create an instance parametrised by any type from scala.*. Maybe the blacklist should also include java.lang.*, java.util.* and the like. What do you think?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how macwire selects wiring candidates and reports a missing String dependency. Define which scala., java.lang., java.util.*, and similar types should be excluded, then verify that forgotten manually-created dependencies produce the intended diagnostic without excluding valid candidates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100