softwaremill / softwaremill/chimp
Consider making client notification a stream
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Scala
- Stars
- 102
- Forks
- 10
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 16
Description
Instead or along side of the current API:
client.onServerNotification:
case ServerNotification.Progress(params) => println(s"progress: ${params.progress}")
case ServerNotification.LoggingMessage(params) => println(s"log: ${params.data}")
case _ => ()
I would like to have a method that returns Stream[ServerNotification] specific to client effect backend.
client.serverNotifications(): Stream[ServerNotification]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the client.onServerNotification API and the client effect backend that owns it, then trace how ServerNotification values are delivered. Define how client.serverNotifications(): Stream[ServerNotification] should coexist with the current API and verify that progress and logging notifications are observable through the stream.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100