software-mansion / software-mansion/cairo-annotations
Implent `try_from_debug_info_mut`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
When we implement a function with the following signature:
fn try_from_debug_info_mut(sierra_debug_info: &mut DebugInfo) -> Result<Self, Self::Error>;
we could remove elements from the underlying hashmap and take ownership of them when deserialized, thus eliminating the need for cloning.
However, this would result in the function no longer being idempotent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the existing conversion from DebugInfo and the definition or callers of try_from_debug_info_mut. Read how cloning and repeated conversion are currently handled, then determine the ownership and idempotence requirements; done means the proposed function behavior is documented and verified against those requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100