software-mansion / software-mansion/TypeGPU
[RFC] fix: Verify that function ends with `return`
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 3.2k
- Forks
- 122
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 34
Description
it('...', () => {
const fn = () => {
'use gpu';
const value = false;
if (value) {
return 1;
}
};
expect(tgpu.resolve([fn])).toMatchInlineSnapshot(`
"fn fn_1() -> i32 {
const value = false;
if (value) {
return 1;
}
}"
`);
});
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the inline test showing tgpu.resolve([fn]) and the generated snapshot. Trace how the function body is validated or translated, then add coverage for the missing final return and confirm the resulting behavior in the snapshot test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100