software-mansion / software-mansion/TypeGPU

fix: Array casts

Open
#2,521 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
3.2k
Forks
122
Avg merge
3d 5h
Merged PRs (30d)
34

Description

Problem analogous to #2450.
For example, here we generate invalid wgsl:

  it('...', () => {
    const A = d.arrayOf(d.struct({ p: d.u32 }), 4);
    const B = d.arrayOf(d.struct({ p: d.f32 }), 4);

    const helper = tgpu.fn([B])((b) => {
      'use gpu';
    });

    const main = tgpu.fn([])(() => {
      'use gpu';
      const a = A();
      helper(a);
    });

    expect(tgpu.resolve([main])).toMatchInlineSnapshot(`
      "struct item {
        p: u32,
      }

      struct item_1 {
        p: f32,
      }

      fn helper(b: array<item_1, 4>) {

      }

      fn main() {
        let a = array<item, 4>();
        helper(a);
      }"
    `);
  });

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the inline reproduction with issue #2450, then trace d.arrayOf, tgpu.fn, and tgpu.resolve to find where array argument types are handled. The work is done when the reproduction no longer generates an invalid WGSL call and the corresponding inline snapshot passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers, computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.