software-mansion / software-mansion/TypeGPU

dx: Lint `.toEqual` in tests

Open
#2,479 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

internal-dx
Dominant language
TypeScript
Stars
3.2k
Forks
122
Avg merge
3d 5h
Merged PRs (30d)
34

Description

Blocked by #2345

For primitives, we prefer .toBe, and otherwise we prefer .toStrictEqual

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the blocker in #2345, then inspect the TypeScript test files for .toEqual usages. Replace primitive comparisons with .toBe and other comparisons with .toStrictEqual, and verify that the test suite still passes with no remaining inappropriate .toEqual calls.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.