software-mansion / software-mansion/TypeGPU

bug: wrapping shelled function in a shell throws an error

Open
#2,453 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
3.2k
Forks
122
Avg merge
3d 5h
Merged PRs (30d)
34

Description

Let's assume that some library expects a callback and wraps it in a shell for type safety.
If user is familiar with typegpu, they might pass a shelled function instead of plain js function. Currently, this throws an error.

function someFunc(callback: (...args: number[]) => void) {
  ...
  const wrappedCallback = fn([u32, u32, u32])(callback as (...args: number[]) => void);
}
const shelled = tgpu.fn([u32, u32, u32])((x, y, z) => { ... });

someFunct(shelled); ❌

IMO, if all types match, this should be a no-op (modulo assigning name).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the shown tgpu.fn and fn examples, focusing on wrapping a shelled function as a callback. Trace the fn wrapping entry point and verify that matching types no longer throw, while the wrapped function still receives its assigned name.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.