software-mansion / software-mansion/TypeGPU

chore: Investigate Vector3 in three.js

Open
#1,944 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
3.2k
Forks
122
Avg merge
3d 5h
Merged PRs (30d)
34

Description

The following seems to create vec4f array under the hood:

  const attractorsPositions = uniformArray([
    new THREE.Vector3(-1, 0, 0),
    new THREE.Vector3(1, 0, -0.5),
    new THREE.Vector3(0, 0.5, 1),
  ]);

This makes the following not work as intended:

  const attractorsPositionsAccess = fromTSL(attractorsPositions, {
    type: d.arrayOf(d.vec3f),
  });

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the uniformArray example with the three THREE.Vector3 values and inspect how fromTSL handles the declared d.arrayOf(d.vec3f) type. Trace the conversion that produces vec4f values and determine what behavior is expected for the vec3f declaration.

Written by the indexing model from the issue text.

Assessment

Tech stack
three.js, typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.