software-mansion / software-mansion/TypeGPU

fix: querySets are not deleted with consecutive withPerformanceCallback calls

Open
#1,931 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
3.2k
Forks
122
Avg merge
3d 5h
Merged PRs (30d)
34

Description

Scenario 1:

const pipeline = ... createPipeline();

//...

const draw = () => {
  pipeline.withPerformanceCallback(...).draw(...);
}

We never delete existing querySets. This causes errors, because eventually, the browser cannot allocate any new querySet.


Scenario 2:

const pipeline = ... createPipeline().withPerformanceCallback(...);

//...

const draw = () => {
  pipeline.withPerformanceCallback(...).draw(...);
}

This doesn't cause any trouble, because we allocate a single querySet and reuse it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the withPerformanceCallback implementation and trace how querySets are allocated in the two scenarios described. Reproduce consecutive callback calls in a WebGPU environment, then verify that replaced querySets are deleted and repeated draws no longer exhaust browser querySet allocation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.