software-mansion / software-mansion/TypeGPU
fix: querySets are not deleted with consecutive withPerformanceCallback calls
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 3.2k
- Forks
- 122
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 34
Description
Scenario 1:
const pipeline = ... createPipeline();
//...
const draw = () => {
pipeline.withPerformanceCallback(...).draw(...);
}
We never delete existing querySets. This causes errors, because eventually, the browser cannot allocate any new querySet.
Scenario 2:
const pipeline = ... createPipeline().withPerformanceCallback(...);
//...
const draw = () => {
pipeline.withPerformanceCallback(...).draw(...);
}
This doesn't cause any trouble, because we allocate a single querySet and reuse it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the withPerformanceCallback implementation and trace how querySets are allocated in the two scenarios described. Reproduce consecutive callback calls in a WebGPU environment, then verify that replaced querySets are deleted and repeated draws no longer exhaust browser querySet allocation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100