software-mansion-labs / software-mansion-labs/react-native-bottom-sheet
Feature Request: Enhance scroll negotiation to pass off gesture to nested scroll view at max detent
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 432
- Forks
- 21
- Avg merge
- 7d 7h
- Merged PRs (30d)
- 1
Description
When the bottom sheet reaches its maximum detent, would it be possible for a continuous upward scroll gesture to be handed off to nested scrollable content? Currently, the BottomSheet appears to continue handling the upward gesture after it is fully expanded (onPositionChange fires with the same value multiple times).
I can provide a screen capture if necessary but I'm just looking at how Apple handles this in some of its own apps.
The sheet will transfer the gesture to the nested scroll view and allow it to start scrolling in a single pan gesture, as opposed to one gesture that moves the sheet to its top position, then another gesture to start scrolling the nested content.
Let me know if a screen capture would help, but the basis of this request mostly comes from using the sheet component in Apple's native apps.
Thank you for taking the initiative for providing a native bottom sheet for React Native apps!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the BottomSheet gesture handling and the onPositionChange behavior described in the issue, then reproduce an upward pan with nested scrollable content while the sheet reaches its maximum detent. Done means one continuous upward gesture transfers from the fully expanded sheet to the nested scroll view, without repeated unchanged position events or requiring a second gesture.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100