softprops / softprops/action-gh-release

Feature request: Wait for all Asset uploads to complete before publishing release

Open
#511 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
TypeScript
Stars
5.8k
Forks
642
Avg merge
47m
Merged PRs (30d)
2

Description

Hello, we have been successfully using this action to auto-publish releases that contain ~12.5 GB of binaries (game engine) split into multiple files. However, it seems like the action 'publishes' the release (in the sense that it is available for users to download files from and webhooks announcing release are fired) before all Assets are uploaded. This leads to a confusing first few minutes after release where it looks like the build has somehow failed because most of the files are missing from the release. In actuality, they are still being uploaded and the action is still running.

Could the current behavior lead to an error case where the release is published, but uploading fails, resulting in an incomplete yet published release?

Can the action be extended to allow waiting to publish until all assets have finished uploading? I don't see anything in the readme that suggests it would be possible with the currently available options.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the action's release publication and asset-upload flow, then review the README options described in the issue. Determine how publication timing and upload failures are currently handled; done means the action can support waiting for all assets before users and webhooks see the release, with the incomplete-upload case defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.