sockjs / sockjs/sockjs-node

Rename option heartbeat_delay to server_heartbeat_interval

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.1k
Forks
306
PR merge metrics
No merged PRs in 30d

Description

To fulfill sockjs/sockjs-client#67 we need to rename option heartbeat_delay to server_heartbeat_interval.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the sockjs-node repository for all references to heartbeat_delay and review the surrounding option handling and tests. Rename the option to server_heartbeat_interval consistently, then verify that the old name is no longer used and existing behavior remains covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.