WebTransport ignores query parameters in URL
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 63.2k
- Forks
- 10.3k
- Avg merge
- 11d 20h
- Merged PRs (30d)
- 2
Description
Describe the bug
The final WebTransport URL doesn't include the query parameters from the original URL.
To Reproduce
engine.io-client 6.6.4
Client
// Connects to: https://localhost:1234/engine.io/?x=y&EIO=4&transport=polling&t=zsyh7czl
eio("https://localhost:1234/?x=y", {transports: ["polling"]});
// Connects to: wss://localhost:1234/engine.io/?x=y&EIO=4&transport=websocket
eio("https://localhost:1234/?x=y", {transports: ["websocket"]});
// Connects to: https://localhost:1234/engine.io/
eio("https://localhost:1234/?x=y", {transports: ["webtransport"]});
Expected behavior
The WebTransport transport should preserve the query parameters in the same way other transports do.
Additional context
WebTransport currently uses createUri to construct the URL:
It doesn't include the original query parameters:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading packages/engine.io-client/lib/transports/webtransport.ts at the linked URL construction and compare it with packages/engine.io-client/lib/transport.ts at the linked query-handling code. Reproduce the three client examples, then verify that the WebTransport URL preserves the original query parameters like the polling and websocket URLs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100