Inconsistent behavior of close packet processing in websocket and polling transports
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 63.2k
- Forks
- 10.3k
- Avg merge
- 11d 20h
- Merged PRs (30d)
- 2
Description
Describe the bug
In the engine.io WebSocket transport, when a close packet is received, it is sent to the top in onPacket and the connection continues functioning as if nothing happened. In contrast, the polling transport closes the client and sends the close event to the top in onClose.
To Reproduce
Engine.IO server and client version: 72d61da Send close packet from server to client.
Expected behavior
All transports should handle data processing consistently.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the WebSocket and polling transport paths named in the report, especially onPacket and onClose, and reproduce the behavior using the stated Engine.IO version with a server-sent close packet. Done means both transports process the close packet consistently, close the client as appropriate, and expose the same close event behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100