snowplow / snowplow/snowplow-javascript-tracker
Make it possible to use the empty string as the custom referer
Open
Nobody has claimed this yet.
category:browser
type:enhancement
- Dominant language
- TypeScript
- Stars
- 590
- Forks
- 232
- Avg merge
- 2h 22m
- Merged PRs (30d)
- 3
Description
At the moment this fails due to the falsiness of ''.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the TypeScript handling for the custom referer option and the related tests, then reproduce the failure with an empty string. Update the behavior so an empty custom referer is accepted and add or adjust coverage to demonstrate that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100