snowplow / snowplow/snowplow-javascript-tracker
Properly allow for type SelfDescribingJSON to be added on `addGlobalContexts`
Open
Nobody has claimed this yet.
type:defect
- Dominant language
- TypeScript
- Stars
- 590
- Forks
- 232
- Avg merge
- 2h 22m
- Merged PRs (30d)
- 3
Description
Describe the bug
Currently the addGlobalContexts function does not allow for typed SelfDescribingJSON schemas to be added.
To Reproduce
Expected behavior
The addGlobalContexts function allows for proper SelfDescribingJSON objects to be passed to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the TypeScript definition and implementation of addGlobalContexts, then trace the SelfDescribingJSON type used by its arguments. Reproduce the reported typing failure with a typed SelfDescribingJSON object and add or update a focused test; done means valid typed objects are accepted without weakening the intended type checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100