snowflakedb / snowflakedb/snowpark-python

SNOW-755114: Get issues when code contains "$$$$" using version 1.2.0 because of "support for displaying source code as comments"

Open
#713 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
341
Forks
155
Avg merge
4d 16h
Merged PRs (30d)
27

Description

Please answer these questions before submitting your issue. Thanks!

  1. What version of Python are you using?

    Python 3.8.14 (default, Sep 6 2022, 23:17:06)
    [Clang 13.1.6 (clang-1316.0.21.2.5)]

  2. What operating system and processor architecture are you using?

macOS-13.2.1-arm64-arm-64bit

  1. What are the component versions in the environment (pip freeze)?

artifacts-keyring==0.3.2
asn1crypto==1.5.1
avautility==0.0.23
certifi==2022.12.7
cffi==1.15.1
charset-normalizer==2.1.1
cloudpickle==2.0.0
cryptography==39.0.1
filelock==3.9.0
idna==3.4
importlib-metadata==6.0.0
importlib-resources==5.12.0
jaraco.classes==3.2.3
keyring==23.13.1
more-itertools==9.1.0
numpy==1.24.2
oscrypto==1.3.0
pandas==1.5.3
pyarrow==10.0.1
pycparser==2.21
pycryptodomex==3.17
PyJWT==2.6.0
pyOpenSSL==23.0.0
python-dateutil==2.8.2
pytz==2022.7.1
requests==2.28.2
six==1.16.0
snowflake-connector-python==3.0.0
snowflake-snowpark-python==1.2.0
typing_extensions==4.5.0
urllib3==1.26.14
zipp==3.15.0

  1. What did you do?

the python code contains "$$$$"

  1. What did you expect to see?

because 1.2.0 has supported for displaying source code as comments. So it will have problems when the code has string "$$$$". I think we can escaping these characters. Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with Python code containing "$$$$" while using snowpark-python 1.2.0, then trace the handling introduced for displaying source code as comments. Confirm the behavior against a case without those characters and define done as preserving the source correctly without interpreting or corrupting the dollar signs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.