snowflakedb / snowflakedb/snowpark-python
SNOW-1358930: fix_drift_between_column_sf_type_and_dtype maps DecimalType to Int64
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 341
- Forks
- 155
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 27
Description
fix_drift_between_column_sf_type_and_dtype defined in src/snowflake/snowpark/mock/_util.py is mapping DecimalType to int64, but DecimalType (i.e. fixed point numbers) is not always integer, this is causing tests like tests/integ/test_column.py:: test_column_with_builtins_that_shadow_functions to fail.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/snowflake/snowpark/mock/_util.py at fix_drift_between_column_sf_type_and_dtype, then run tests/integ/test_column.py::test_column_with_builtins_that_shadow_functions. Trace the DecimalType handling and verify the failing test passes without converting non-integer fixed-point values to an integer dtype.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-engineering
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100