snowflakedb / snowflakedb/snowflake-ingest-java

ingest.connection.RequestBuilder is overly restrictive on requestId parameters

Open
#593 0 comments 0 reactions 1 assignee View on GitHub

@sfc-gh-rramachandran is already working on this.

Since Oct 5, 2023.

feature request snowpipe
Dominant language
Java
Stars
83
Forks
70
Avg merge
1d 7h
Merged PRs (30d)
6

Description

Background

According to the official file data ingestion API documentation is described as:

requestId: (required No) String used to track requests through the system. We recommend providing a random string with each request, e.g. a UUID.

This clearly indicates an insertFiles request should not have to supply a request ID, but also, that a UUID is only recommended but not required.

However, as written, there way to invoke RequestBuilder.generateInsertRequest(...) without providing an externally generated UUID.

Implementors should be allowed to provide any string value to this argument, or optionally not supply one at all.

Feature Request

Requesting any of the following:

  • additional overloads of RequestBuilder.generateInsertRequest(...) and RequestBuilder.generateHistoryRequest(...) which accept a requestId as a String parameter
  • permit null or "" values for requestId parameters on these methods, or provide additional method overloads without these arguments

or

  • Open up most or all private methods in class RequestBuilder to allow implementers extend this functionality themselves

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.