snowflakedb / snowflakedb/snowflake-ingest-java
ingest.connection.RequestBuilder is overly restrictive on requestId parameters
@sfc-gh-rramachandran is already working on this.
Since Oct 5, 2023.
- Dominant language
- Java
- Stars
- 83
- Forks
- 70
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 6
Description
Background
According to the official file data ingestion API documentation is described as:
requestId: (required No) String used to track requests through the system. We recommend providing a random string with each request, e.g. a UUID.
This clearly indicates an insertFiles request should not have to supply a request ID, but also, that a UUID is only recommended but not required.
However, as written, there way to invoke RequestBuilder.generateInsertRequest(...) without providing an externally generated UUID.
Implementors should be allowed to provide any string value to this argument, or optionally not supply one at all.
Feature Request
Requesting any of the following:
- additional overloads of
RequestBuilder.generateInsertRequest(...)andRequestBuilder.generateHistoryRequest(...)which accept arequestIdas aStringparameter - permit
nullor""values forrequestIdparameters on these methods, or provide additional method overloads without these arguments
or
- Open up most or all
privatemethods in classRequestBuilderto allow implementers extend this functionality themselves
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.