snowflakedb / snowflakedb/snowflake-connector-python
SNOW-1004630: Combine-coverage should only run if build succeeded
Open
Nobody has claimed this yet.
enhancement
status-triage_done
- Dominant language
- Python
- Stars
- 730
- Forks
- 574
- Avg merge
- 5h 45m
- Merged PRs (30d)
- 16
Description
https://github.com/snowflakedb/snowflake-connector-python/blob/ca8a58060b603e1da462531139da2eefddd822b5/.github/workflows/build_test.yml#L332
Combine-coverage should run when tests pass, or fail. However; there's no point in running it if a build failed and tests won't even start.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open .github/workflows/build_test.yml around line 332 and inspect the combine-coverage step and the preceding build and test steps. Confirm the workflow condition so coverage runs after tests pass or fail, but is skipped when the build fails; validate the workflow syntax if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100