snowflakedb / snowflakedb/snowflake-connector-python

SNOW-777765: Interpolate empty sequences in queries by default

Open
#1,497 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

behavior change feature status-triage_done triaged
Dominant language
Python
Stars
730
Forks
574
Avg merge
5h 45m
Merged PRs (30d)
16

Description

What is the current behavior?

As part of https://github.com/snowflakedb/snowflake-connector-python/issues/961, the interpolate_empty_sequences connection parameter was added (https://github.com/snowflakedb/snowflake-connector-python/pull/997), defaulting to False for backward compatibilty.

What is the desired behavior?

The interpolate_empty_sequences=True behavior should be the default (and, if not done right away, the parameter and old behavior eventually removed).

How would this improve snowflake-connector-python?

The interpolate_empty_sequences=False behavior is inconsistent with other database adapters (as demonstrated by both Django and SQLalchemy).

References, Other Background

https://github.com/snowflakedb/snowflake-connector-python/issues/961#issuecomment-984160680 was left open for this change, but automatically closed due to being older than six months.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the interpolate_empty_sequences connection parameter introduced in issue 961 and PR 997, then inspect how empty sequences are handled during query interpolation. Done means the True behavior is the default, with the old parameter behavior and eventual removal considered consistently with the Django and SQLAlchemy references.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.