smol-rs / smol-rs/async-executor

Push task directly to the local queue

Open
#62 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
459
Forks
52
Avg merge
6h 53m
Merged PRs (30d)
1

Description

This was originally implemented in #37, but the implementation turned out to be very buggy so I removed it in #61. Still, I think it's an important optimization even for a reference executor, as it nearly doubles our performance in micro-benchmarks.

https://github.com/smol-rs/async-executor/blob/8a0832c090625dd36e66ff7b42a76a80b421f90f/src/lib.rs#L257

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/lib.rs around line 257, then review the original implementation in #37 and its removal in #61 to understand the prior failure. Reproduce the relevant micro-benchmarks and determine the safe local-queue behavior; done means the optimization is restored without the bugs that prompted its removal and the performance improvement is demonstrated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.