smarty-php / smarty-php/smarty
ForEach unrecognized Syntax Error on double brackets {{}}
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.3k
- Forks
- 709
- PR merge metrics
- No merged PRs in 30d
Description
I have "{" and "}" characters set as my delimiters. I made a syntax error and closed my foreach loop with double brackets.
{ foreach $var as $vars }
{* code here *}
{{ /foreach }} // <---- SYNTAX ERROR
Not only did Smarty not warn me of the error but it parsed the code and executed. Needless to say this was hard to diagnose because the error spilled out into multiple templates and even my normal php scripts and that was due to the foreach loop using an output buffer layer for each iteration that when unproperly closed and not handled by smarty as error get carried over to general scripts.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the malformed foreach template using the configured { and } delimiters, then trace the foreach parsing and output-buffer handling. The fix is done when a double-bracket closing tag is rejected as a syntax error and does not leak buffered output into other templates or PHP scripts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100