smarty-php / smarty-php/smarty

Tests failures with smarty 4.5.6 and php 8.5

Open
#1,184 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
2.3k
Forks
709
No merged PRs in 30d

Description

PHPUnit 8.5.52 by Sebastian Bergmann and contributors.
Runtime:       PHP 8.5.6RC1
Configuration: /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/phpunit.xml

...

Summary of non-successful tests:

Extends Resource
 ✘ CompileBlockGrandChildMustCompile 021 3 [0.00 ms]
   │
   │ PHPUnit\Framework\Exception: PHP Deprecated:  Using null as an array offset is deprecated, use an empty string instead in /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php on line 75
   │ Deprecated: Using null as an array offset is deprecated, use an empty string instead in /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php on line 75
   │

 ✘ CompileBlockGrandChildMustCompile 021 4 [0.00 ms]
   │
   │ PHPUnit\Framework\Exception: PHP Deprecated:  Using null as an array offset is deprecated, use an empty string instead in /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php on line 75
   │ Deprecated: Using null as an array offset is deprecated, use an empty string instead in /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php on line 75
   │

Php Resource
 ✘ Create cache file [2.31 ms]
   │
   │ Using null as an array offset is deprecated, use an empty string instead
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php:75
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php:42
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_cached.php:143
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:212
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:238
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:116
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/ResourceTests/Php/PhpResourceTest.php:113
   │

 ✘ Get cached timestamp [9.11 ms]
   │
   │ Failed asserting that false is true.
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/ResourceTests/Php/PhpResourceTest.php:129
   │

 ✘ Is cached [9.04 ms]
   │
   │ Failed asserting that false is true.
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/ResourceTests/Php/PhpResourceTest.php:146
   │

 ✘ Write cached content [3.16 ms]
   │
   │ Using null as an array offset is deprecated, use an empty string instead
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php:75
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php:42
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_cached.php:143
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:212
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:238
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:116
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/ResourceTests/Php/PhpResourceTest.php:199
   │

 ✘ Smarty is cached prepare [2.29 ms]
   │
   │ Using null as an array offset is deprecated, use an empty string instead
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php:75
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_updatecache.php:42
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_cached.php:143
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:212
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:238
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:116
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/ResourceTests/Php/PhpResourceTest.php:226
   │

 ✘ Smarty is cached [8.93 ms]
   │
   │ Failed asserting that false is true.
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/ResourceTests/Php/PhpResourceTest.php:241
   │

Compile Block Extends
 ✘ Escaping [3.05 ms]
   │
   │ Using null as an array offset is deprecated, use an empty string instead
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_resource_extends.php:48
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_source.php:182
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:330
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_inheritance.php:115
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/TemplateSource/TagTests/BockExtend/templates_c/3088f55ce2474a7e7b32708a52454bb0bc59d5e1_0.file.escaping.tpl.php:26
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_resource_base.php:123
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_compiled.php:114
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:217
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:238
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:116
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/TemplateSource/TagTests/BockExtend/CompileBlockExtendsTest.php:1385
   │

 ✘ Escaping [2.58 ms]
   │
   │ Using null as an array offset is deprecated, use an empty string instead
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_resource_extends.php:48
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_source.php:182
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:330
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_inheritance.php:115
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/TemplateSource/TagTests/BockExtend/templates_c/7e1d59ab0b224d193e8b9414785a9917b1672d81_0.file.escaping2.tpl.php:26
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_resource_base.php:123
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_compiled.php:114
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:217
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:238
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:116
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/TemplateSource/TagTests/BockExtend/CompileBlockExtendsTest.php:1395
   │

 ✘ Escaping [2.72 ms]
   │
   │ Using null as an array offset is deprecated, use an empty string instead
   │
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_resource_extends.php:48
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_source.php:182
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:330
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_runtime_inheritance.php:115
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/TemplateSource/TagTests/BockExtend/templates_c/14a870cf54a97b7acb4680ba0c72595415054dc9_0.file.escaping3.tpl.php:26
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_resource_base.php:123
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_template_compiled.php:114
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_template.php:217
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:238
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/libs/sysplugins/smarty_internal_templatebase.php:116
   │ /builddir/build/BUILD/php-smarty4-4.5.6-build/smarty-4.5.6/tests/UnitTests/TemplateSource/TagTests/BockExtend/CompileBlockExtendsTest.php:1405
   │

Compile Include
 ⚠ Include filename escaping [4.02 ms]
   │
   │ expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.
   │

Extends Issue419
 ⚠ Extends security [2.55 ms]
   │
   │ expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.
   │

ERRORS!
Tests: 2316, Assertions: 3331, Errors: 8, Failures: 3, Warnings: 2.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failures from phpunit.xml on PHP 8.5.6RC1, then inspect libs/sysplugins/smarty_internal_runtime_updatecache.php:75 and libs/sysplugins/smarty_internal_resource_extends.php:48. Use tests/UnitTests/ResourceTests/Php/PhpResourceTest.php and CompileBlockExtendsTest.php to understand the affected cases; done means the reported errors and failures no longer occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.