smartcontractkit / smartcontractkit/libocr
Cannot use custom discoverer because the interface requires internal package as arg
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 82
- Forks
- 64
- PR merge metrics
- No merged PRs in 30d
Description
See here:
https://github.com/smartcontractkit/libocr/blob/master/ragep2p/ragep2p.go#L1531
Discoverer requires a Start() method that takes a loghelper.LoggerWithContext argument, but loghelper is an internal package so you cannot actually supply custom discoverers defined outside of libocr.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ragep2p/ragep2p.go around line 1531 and inspect the Discoverer interface and its Start method. Determine how the internal loghelper.LoggerWithContext parameter prevents external implementations; done means a custom discoverer outside libocr can implement and use the interface without importing that internal package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100