smartcontractkit / smartcontractkit/chainlink
Require can be changed to custom revert
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 8.2k
- Forks
- 2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 202
Description
Description
require can be refactored to customRevert
https://github.com/smartcontractkit/chainlink/blob/7b06aa196e4944d93d86ada858de80a9afe79da8/contracts/src/v0.8/KeepersVRFConsumer.sol#L85-L93
In the below code, custom revert is used.
https://github.com/smartcontractkit/chainlink/blob/7b06aa196e4944d93d86ada858de80a9afe79da8/contracts/src/v0.8/PermissionedForwardProxy.sol#L29-L32
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with contracts/src/v0.8/KeepersVRFConsumer.sol at lines 85-93 and compare it with the custom-revert usage in contracts/src/v0.8/PermissionedForwardProxy.sol at lines 29-32. Replace the referenced require usage with customRevert and verify the resulting contract change preserves the intended revert behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100