smartcontractkit / smartcontractkit/chainlink
[SMRT] Invalid Solhint setup
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 8.2k
- Forks
- 2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 202
Description
Description
The Solhint linting tool appears to silently swallow errors.
Basic Information
The solhint setup in the main repo doesn't seem to be working, it may be failing silently because of the way the scripts are set up.
Steps to Reproduce
For example if you run the following in the contracts repo:
"lint:sol": "solhint --config .solhint.json \"src/v0.8/*.sol\""
You get the following error for several contracts:
src/v0.8/VRFV2Wrapper.sol
2:1 error Compiler version ^0.8.6 does not satisfy the ^0.5.8 semver requirement compiler-version
Additional Information
Check out bug/solhint and run:
cd contracts
yarn lint:sol
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the contracts repository at the lint:sol script and .solhint.json, then run yarn lint:sol on the bug/solhint branch as described. Check why the compiler-version error is swallowed; done means the Solidity lint command reports such errors instead of silently succeeding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100