smartcontractkit / smartcontractkit/chainlink
[SMRT] `answeredInRound` deprecated
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 8.2k
- Forks
- 2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 202
Description
Description
In our price feed proxies have this line:
https://github.com/smartcontractkit/chainlink/blob/e1e78865d4f3e609e7977777d7fb0604913b63ed/contracts/src/v0.6/EACAggregatorProxy.sol#L140
answeredInRound is a legacy variable from when the answer could be in a different round.
Suggestion:
Remove the comment in the code suggesting to users to check answeredInRound or at least mention this is a deprecated feature. @thodges-gh
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open contracts/src/v0.6/EACAggregatorProxy.sol at the referenced line and inspect the comment about checking answeredInRound. Update or remove the guidance to reflect that answeredInRound is deprecated; the work is done when the misleading recommendation is no longer present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100