smartcontractkit / smartcontractkit/chainlink

tag job errors in error logs as errors

Open
#6,785 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

investigating
Dominant language
Go
Stars
8.2k
Forks
2k
Avg merge
1d 23h
Merged PRs (30d)
202

Description

Beginning with Chainlink version smartcontract/chainlink:1.3.1-nonroot the log formatting seems to have changed such that entries that are actually errors are tagged as 'debug' (along with many other entries that are non-critical errors or purely informational)

for example:

2022-06-10T12:06:07.795Z        **debug**   1.4.1@73e70a9   Pipeline task completed {"jobID": 0, "jobName": "", "taskName": "ds1", "taskType": "bridge", "attempt": 0, "runInfo": {"IsRetryable":true,"IsPending":false}, "resultValue": null, **"resultError"**: "got error from XXX?source=coingecko: (status code 500) ", "resultErrorVerbose": "got error from XXX?source=coingecko: (status code 500).....}

The vast majority of log entries are tagged as 'debug' as above, this one is actually an error.
Would it be possible to tag errors with something along the lines of:

2022-06-10T12:06:07.795Z       **error**    1.4.1@73e70a9   Pipeline task completed {....}

This would make identifying errors in the logs significantly easier.
Thanks for reviewing and considering!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Chainlink code that logs pipeline task completion and inspect how resultError is represented in the example. Reproduce the logging behavior with a failed pipeline task, then verify that entries containing an actual task error are emitted at error level while informational completions remain debug.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.