smartcontractkit / smartcontractkit/chainlink

[SMRT] relax version requirements for interfaces and libraries

Open
#16,660 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
8.2k
Forks
2k
Avg merge
1d 23h
Merged PRs (30d)
202

Description

Description
The interfaces and libraries for data-streams use a pinned version (at the moment 0.8.19) which make them unusable in most projects that want to import them as dependencies. This is because it forces dependents to use the same version, which is often not possible.

Basic Information
The interfaces and libraries which have a too restrictive version pragma are here:

https://github.com/smartcontractkit/chainlink/tree/develop/contracts/src/v0.8/llo-feeds

A suggestion would be to use ^0.8.0 or even >=0.8.0 for interfaces.

Steps to Reproduce
N/A

Additional Information
N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Solidity interfaces and libraries under contracts/src/v0.8/llo-feeds and locate the pinned 0.8.19 version pragmas. Check how each package is intended to be imported as a dependency. Done means the unnecessarily restrictive version requirements are relaxed while preserving compatibility across the affected interfaces and libraries.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.