smartcontractkit / smartcontractkit/chainlink-cosmos

Deduplicate 'pub mod bignum' declaration

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

@archseer is already working on this.

Since Dec 29, 2021.

Dominant language
Go
Stars
23
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Both contracts/ocr2/src/state.rs and contracts/deviation-flagging-validator/src/msg.rs contain the identical pub mod bignum {...} declaration we should consider deduplicating.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the declarations in contracts/ocr2/src/state.rs and contracts/deviation-flagging-validator/src/msg.rs, then inspect the surrounding module layout for an existing shared-module convention. Run the relevant contract checks or builds and consider the work done when the duplicated declaration has a single clear home and both contracts still compile.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.