Throw exception when opening file fails
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.7k
- Forks
- 579
- Avg merge
- 2m
- Merged PRs (30d)
- 1
Description
parseFile method only raises a notice when it fails to get the file. This complicates diagnostics because the library won’t fail until it tries to parse the response.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Smalot/PdfParser/Parser.php at the parseFile method referenced by the issue, and inspect the path taken when obtaining the file fails. Confirm the current notice behavior and check the existing test suite for related parser cases. Done means the failure raises an exception immediately instead of continuing to parse an invalid response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100