smacke / smacke/ffsubsync

Ignoring descriptive subtitles

Open
#69 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.9k
Forks
323
PR merge metrics
No merged PRs in 30d

Description

First of all, thanks a lot, this is a great tool and now I can watch my new favourite series without being spoiled by the subtitles :-)
In the description you say that sometimes the timing is not perfect, and in the case of my series I think I know why: there are a lot of descriptive subtitles like [COUNTRY MUSIC PLAYING] or [METALLIC NOISE], and the algorithm also consider those subtitles to align them with speech whereas no one is speaking. So I guess if in the parsing we could ignore these kind of subtitles, usually in capital letter and between brackets, then the alignment would be better. The discarded subtitles could be either completely discarded or put back between their 2 surrounding normal subtitles, optionally with a linear interpolation to put them closer to the subtitle they where originally closer to.
Again, thanks a lot!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name files or tests. Start by locating the subtitle parsing and alignment entry points, then trace how descriptive lines such as bracketed, uppercase sound cues are handled. Done should mean these cues no longer distort speech alignment, with their handling matching the chosen behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
audio-video-rtc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.