smacke / smacke/ffsubsync

[Feature Request] Force voice activity synchronization

Open
#210 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7.9k
Forks
323
PR merge metrics
No merged PRs in 30d

Description

First off, this tool is one of the most useful and well functioning programs ever and saved me so much time, so thank you.

The only thing that I have run into that I would like to see added as a CLI option is when using .mkv as an input, have the option to force voice activity synchronization and ignore any embedded text based subtitles that may be inside the mkv container.

The reason I think this feature would be a good addition is because I've often found the voice activity synchronization to be much more accurate for foreign language subtitles than syncing based off an English text based subtitle due to the differences in how a foreign language subtitle and English source subtitle may be structured OR if the only reference English subtitle available is an SDH subtitle and the foreign language subtitles you are trying to sync are non-SDH.

Without this feature, I've had to remux my mkv files to remove the subtitles in a temporary mkv file or extract the audio from the mkv file first and then sync which adds an extra step to subtitle syncing.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CLI option handling and the code that selects embedded subtitles from MKV inputs. Trace how voice activity synchronization is chosen relative to text-based subtitles, then identify the tests covering subtitle selection and synchronization. Done means a CLI option can force voice activity synchronization while ignoring embedded text subtitles.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.