smacke / smacke/ffsubsync

how to prevent skipping

Open
#130 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

out-of-sync
Dominant language
Python
Stars
7.9k
Forks
323
PR merge metrics
No merged PRs in 30d

Description

I an sync on some japanese subs and saw this turns out it skips the first two lines in the sub file I dont get why for reference heres the first few lines

1
00:00:06,172 --> 00:00:08,375
今から100年以上前

2
00:00:09,075 --> 00:00:11,678
人類にある天敵が現れた

3
00:00:16,750 --> 00:00:21,688
彼らと人類の間には
圧倒的な力の差が存在し―

       INFO     Skipped subtitle at index 1: Start time < 0      srt.py:281
                seconds                                                    
       INFO     Skipped subtitle at index 2: Start time < 0      srt.py:281
                seconds     

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at srt.py:281 and reproduce the report with the Japanese SRT excerpt from the issue. Trace how the first subtitle start times are parsed and why indexes 1 and 2 are reported as earlier than 0 seconds. Done means the handling of these entries is understood and the issue’s expected behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
audio-video-rtc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.