smacke / smacke/ffsubsync

Awesome idea, room for improvement

Open
#10 16 comments 36 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
7.9k
Forks
323
PR merge metrics
No merged PRs in 30d

Description

This is extremely interesting.

I'm the author of Sub-Zero for Plex and a contributor of Bazarr, which take a different approach to "syncing" subtitles to media by matching the release and media metadata to user generated content.

The subsync approach is one I wanted to do for ages.

Sub-Zero (and, at its core, subliminal) relies on proper offset alignment based on user generated content - this works 95% of the time, as subtitles are usually created for a specific release of a media file.

Being able to sync a subtitle based on its start point is awesome, but it's at least as error prone compared to the matching of metadata and relying on the subtitle author to not mess up.

There are a couple of factors that would need to be addressed before subsync could be integrated into one of the existing solutions (just off the top of my head):

  • hearing impaired tags mess up the detection
  • commercial breaks and cuts distort the timing of subtitles even after the initial sub entry has been synced correctly
  • multiline subtitle entries can mess up the entry point of subsync and subsequent entries

I massively applaud the effort and I hope this can be extended to do a lot more and be a lot more accurate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is identified in the issue. Start by reviewing the discussion and the existing subtitle synchronization behavior; a concrete change, acceptance criteria, and validation target would need to be defined before implementation can begin.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
audio-video-rtc
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.