slimtoolkit / slimtoolkit/slim
Ability to exit http probe and fail build when any http probe fails
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.4k
- Forks
- 840
- PR merge metrics
- No merged PRs in 30d
Description
A new CLI argument and / or environment variable (or modification of --http-probe-exit-on-failure / DSLIM_HTTP_PROBE_EXIT_ON_FAILURE) that allows the build to fail when any single http probe fails.
Current behavior is to fail when every http probe fails i.e. when the following condition is true:
probe.CallCount > 0 && probe.OkCount == 0 && opts.httpProbeOpts.ExitOnFailure
....
Would instead want something like
probe.ErrCount > 0 && opts.httpProbeOpts.ExitOnAnyFailure
....
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the HTTP probe exit-on-failure handling associated with --http-probe-exit-on-failure and DSLIM_HTTP_PROBE_EXIT_ON_FAILURE, then inspect the probe.ErrCount and probe.OkCount paths. Done means the build can be configured to fail when any single HTTP probe fails while preserving the current all-probes-failed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100