slimtoolkit / slimtoolkit/slim

`--tag` option not being respected if it contains a commit sha in it

Open
#321 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
Go
Stars
23.4k
Forks
840
PR merge metrics
No merged PRs in 30d

Description

--tag option is not being respected if it contains a commit sha in it

Example:

When running

docker-slim build --sensor-ipc-mode proxy --sensor-ipc-endpoint $(docker network inspect bridge -f '{{range .IPAM.Config}}{{.Gateway}}{{end}}' | cut -f1) --tag gcr.io/myorg/myproj:1234abcd1234abcd1234abcd.slim gcr.io/myorg/myproj:1234abcd1234abcd1234abcd;

I'm getting the following result (excerpt from my logs):

cmd=build info=results has.data='true' image.name='gcr.io/myorg/myproj.slim' image.size='100 MB' 

Info

  • version: 1.37.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the docker-slim build command's --tag option handling and reproduce the supplied command with version 1.37.6. Trace how the tag is carried into the build result, then verify that an image tag containing the commit SHA is retained instead of producing the truncated image name shown in the logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.