slimphp / slimphp/Slim

Slim 5: Ensure that route attributes are always in the Request

Open
#3,280 2 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Slim 5
Dominant language
PHP
Stars
12.3k
Forks
2k
Avg merge
3d 2h
Merged PRs (30d)
6

Description

With the way strategies are currently implement, route parameters are only sometimes set into the Request's attributes.

In Slim 5, we should ensure that they are always in there for consistency purposes and that strategies (if we choose to continue with them) only affect the signature of the callable.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Strategies directory linked in the issue and trace where route parameters are added to the Request. Check the existing strategy behavior and request handling before making changes. Done means route parameters are consistently present in Request attributes, while strategies only affect the callable signature.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.