slackhq / slackhq/vscode-hack

Enable Hack language server with .hhconfig not in root

Open
#94 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
80
Forks
47
PR merge metrics
No merged PRs in 30d

Description

I have a repository that uses a few different programming languages and in order to keep things clean I put the dotfiles to support each language in the folder containing that language's code.

It seems like this extension only supports .hhconfig in the root of the workspace. Would it be possible to support workspaceContains:**/.hhconfig? Or alternatively to add onLanguage:hack to activationEvents?

I'm willing to write and test a Pull Request if this would be an acceptable change?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the extension's activationEvents and its current workspaceContains configuration for .hhconfig. Determine whether nested .hhconfig files or onLanguage:hack should provide activation, then verify that the extension activates for a Hack file or workspace with a non-root .hhconfig.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.